Move get_asset_key_str to translator and add config for translator class #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucargir
changed the title
lucargir
force-pushed
the
main
branch
3 times, most recently
from
b9ac811 to
99f7e6b
Compare
ravenac95
reviewed
Sep 10, 2025
ravenac95
reviewed
Sep 10, 2025
ravenac95
reviewed
Sep 10, 2025
Member
|
Thanks for the changes @lucargir. I generally like it! I made some comments to address |
Contributor
Author
|
@ravenac95 that should be it, lmk if there's anything else. |
Member
|
Hrm. I've discovered that this change actually breaks some encapsulation issues and prevents actually doing real dependency injection (something that OSO had previously relied on). I am going to expose a few options to re-enable this but this is something I'll probably figure out how to refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve #3 and adds the translator config to the config object, so it's more intuitive to use.